Skip to content

Removed support for Python 3.8 #1266

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Jan 7, 2025

Description of the Change

Remove Python 3.8 which is EOL per PEP 569

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk requested a review from sliverc January 7, 2025 16:38
@n2ygk
Copy link
Contributor Author

n2ygk commented Jan 7, 2025

drfmaster tests are throwing an error for TypeError for encode of None. Maybe related to #1229?

@sliverc
Copy link
Member

sliverc commented Jan 7, 2025

There is an upstream change in DRF which caused these errors. I have submitted a PR here encode/django-rest-framework#9615 hope it will be merged soon.

Copy link
Member

@sliverc sliverc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. getting-started.md needs also to be adjusted I think and also add a note in changelog to version 7.1.0 that states that it is the last version supporting 3.7. See how we did it in #1178

@n2ygk
Copy link
Contributor Author

n2ygk commented Jan 9, 2025

@sliverc

Thanks for working on this. getting-started.md needs also to be adjusted I think and also add a note in changelog to version 7.1.0 that states that it is the last version supporting 3.7. See how we did it in #1178

Done.

Also, perhaps as a separate PR, should we make a failed drfmaster test a non-fatal workflow error? That's how we do it in DOT, for example: https://github.com/jazzband/django-oauth-toolkit/blob/master/tox.ini#L57-L59. Right now, errors in non-released DRF are blocking successful PRs here.

@n2ygk
Copy link
Contributor Author

n2ygk commented Jan 9, 2025

See #1267

@sliverc
Copy link
Member

sliverc commented Jan 13, 2025

Thanks looks good.

@sliverc sliverc changed the title Python 3.8 EoL per PEP569 Removed support for Python 3.8 Jan 13, 2025
@sliverc sliverc merged commit 1b5fb9c into django-json-api:main Jan 13, 2025
9 checks passed
@n2ygk n2ygk deleted the deprecate_3.8 branch January 13, 2025 14:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants