Add incremental index #40
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tagging @djc for visibility |
djc
reviewed
Apr 17, 2023
| @@ -170,6 +170,12 @@ where | |||
| pub fn get(&self, i: usize, search: &Search) -> Option<MapItem<'_, P, V>> { | |||
| Some(MapItem::from(self.hnsw.get(i, search)?, self)) | |||
| } | |||
|
|
|||
| pub fn insert(&mut self, point: P, value: V) -> Result<PointId, Box<dyn std::error::Error>> { | |||
There was a problem hiding this comment.
This doesn't seem to ever result an Err, so it doesn't need to be fallible?
Comment on lines
+416
to
+420
| let zeros = self | ||
| .zero | ||
| .iter() | ||
| .map(|z| RwLock::new(z.clone())) | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
This seems like a pretty expensive operation, to the point that calling insert() one-by-one is unlikely to be very effective. Could we yield some construction type here that can be reused to insert multiple points?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a great project! Here's a small contribution 🙂
Adds
inserttoHnswandHnswMap. The goal is to allow for incremental updates to the index by following these steps.Construction.insertI added a simple test to validate the insertion and lookup - however I am no expert and would love any feedback to improve this PR! 🙏
Thank you!