Skip to content

Add agree_guild_rules guild method #664

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alenkimov
Copy link

Summary

Fixes #454

General Info

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue (please put issue # in summary).
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link

@MrOmnomnoshka MrOmnomnoshka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Skorchekd
Copy link

this doesnt work for membership screening.

Copy link
Owner

@dolfies dolfies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not implement the majority of the membership screening/guild join request API. For a preview on how large this API is, see this PR on userdoccers (note that more has been added in following commits).

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Membership Screening rules accept() + view() methods
4 participants