Skip to content

Csharp language reference attributes: add missing AsyncMethodBuilder.SetStateMachine member #45929

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 28, 2025

Conversation

AustinWise
Copy link
Contributor

@AustinWise AustinWise commented Apr 26, 2025

This method is mentioned in the Roslyn documentation:

https://github.com/dotnet/roslyn/blob/main/docs/features/task-types.md

If it is not included when implementing the AsyncMethodBuilder pattern, the C# compiler fails to compile with a CS0656 error.

I also added a public to the Start method to match the other methods described in this section.


Internal previews

📄 File 🔗 Preview link
docs/csharp/language-reference/attributes/general.md Miscellaneous attributes interpreted by the C# compiler

…SetStateMachine member

This method is mentioned in the Roslyn documentation:

https://github.com/dotnet/roslyn/blob/main/docs/features/task-types.md

If it is not included when implementing the AsyncMethodBuilder  pattern, the C# compiler fails to compile with a CS0656 error.

I also added a `public` to the `Start` method to match the other methods described in this section.
@AustinWise AustinWise requested review from BillWagner and a team as code owners April 26, 2025 23:32
@dotnetrepoman dotnetrepoman bot added this to the April 2025 milestone Apr 26, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-csharp/svc lang-reference/subsvc community-contribution Indicates PR is created by someone from the .NET community. labels Apr 26, 2025
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AustinWise

This LGTM, and I'll :shipit: now.

@BillWagner BillWagner merged commit ea56e90 into dotnet:main Apr 28, 2025
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-csharp/svc lang-reference/subsvc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants