Remove System.Drawing #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for your contribution! Due to SixLabors ImageSharp has changed its license, and commercial authorization is required for for-profit organizations with an annual total income of more than $1 million, so we need to consider carefully. 非常感谢您的贡献！由于 SixLabors.ImageSharp变更了授权许可证，对于年总收入高于100万美元的营利性组织需要进行商业授权，因此我们需要慎重考虑。 |
|
Q. What do I need to do as an Open Source or Source Available consumer following these changes? A. Absolutely nothing. No changes are required in any form. The license will continue to be granted to you under the Apache License 2.0. You and any consumers of your work continue to enjoy exactly the same freedom as before. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Magicodes teams, I see request from #440 issue that remove the System.Drawing as it will be disabled in Linux after Net7.
After some research, I think SixLabors.ImageSharp would be a good choice.
So I do some work to change to SixLabors.ImageSharp, and remove the System.Drawing package and related codes.
This pull request is a break change, and need for additional review.
Lastly, this pull request is for review, not for accept, if it is acceptable for your team, there are additional codes to commit for this pull request.