Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

man: doveadm-pw - Replace example DIGEST-MD5 with ARGON2ID #1172

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seanm
Copy link

@seanm seanm commented Feb 13, 2025

No description provided.

@cmouse
Copy link
Contributor

cmouse commented Feb 13, 2025

Hi! Thank you for your pull request. Can you change the commit text to

man: doveadm-pw - Replace example DIGEST-MD5 with ARGON2ID

pull request title does not matter

@seanm seanm changed the title Replaced one of the MD5 examples with ARGON2ID man: doveadm-pw - Replace example DIGEST-MD5 with ARGON2ID Feb 13, 2025
@seanm
Copy link
Author

seanm commented Feb 24, 2025

Hi! Thank you for your pull request. Can you change the commit text to

man: doveadm-pw - Replace example DIGEST-MD5 with ARGON2ID

Done. Any other changes needed?

@cmouse
Copy link
Contributor

cmouse commented Feb 25, 2025

I'm now wondering in SHA512-CRYPT would be better example, argon2 is not a good choice for busy systems.

@seanm
Copy link
Author

seanm commented Feb 25, 2025

There are 2 examples, both MD5. I changed one to ARGON already, how about I change the other to SHA512-CRYPT?

@cmouse
Copy link
Contributor

cmouse commented Feb 25, 2025

lets do that, can you rebase your branch while you're at it?

@seanm
Copy link
Author

seanm commented Feb 25, 2025

lets do that, can you rebase your branch while you're at it?

Done. I also read over the whole file and made a few other tweaks too.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants