Skip to content
This repository was archived by the owner on May 31, 2020. It is now read-only.

call plugin onChange method #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

call plugin onChange method #3

wants to merge 1 commit into from

Conversation

hosmelq
Copy link
Collaborator

@hosmelq hosmelq commented Oct 2, 2018

No description provided.

@juliankrispel
Copy link
Member

@hosmelq I actually think removing onChange from plugin methods simplifies the API. It's also little bit confusing, like - as a user I'm not sure if this means I'm listening to events or updating the state, in the previous versions of plugins this is both - which is imo super confusing.

I don't think it's needed really...

@hosmelq
Copy link
Collaborator Author

hosmelq commented Oct 3, 2018

Perfect, I like the idea. You can close this whenever you want.

@juliankrispel
Copy link
Member

juliankrispel commented Oct 3, 2018 via email

@hosmelq
Copy link
Collaborator Author

hosmelq commented Oct 8, 2018

Gracias @juliankrispel, no sé mucho sobre borrador, pero podría ayudar. 🙂

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants