feat: new hc webhook fields #337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scm/driver/harness/webhook.go
Outdated
| Sha: commit.Sha, | ||
| Ref: ref.Name, | ||
| Author: convertUser(pr.Author), | ||
| Head: scm.Reference{ | ||
| Name: pr.SourceBranch, | ||
| Path: scm.ExpandRef(ref.Name, "refs/heads"), |
There was a problem hiding this comment.
minor use either pr.SourceBranch in both, or ref.Name in both
| @@ -356,15 +358,27 @@ func convertPullReq(pr pullReq, ref ref, commit hookCommit) scm.PullRequest { | |||
| return scm.PullRequest{ | |||
| Number: pr.Number, | |||
| Title: pr.Title, | |||
| Body: pr.Description, | |||
| Closed: pr.State != "open", | |||
| Source: pr.SourceBranch, | |||
| Target: pr.TargetBranch, | |||
| Merged: pr.State == "merged", | |||
| Fork: "fork", | |||
There was a problem hiding this comment.
shouldn't this be empty 🤔
There was a problem hiding this comment.
go-scm/scm/driver/github/pr.go
Line 78 in ecd9254
| Base: scm.Reference{ | ||
| Name: pr.TargetBranch, | ||
| Path: scm.ExpandRef(pr.TargetBranch, "refs/heads"), | ||
| Sha: pr.MergeBaseSHA, |
There was a problem hiding this comment.
mergebasesha isn't necessarily the sha of the targetbranch
There was a problem hiding this comment.
this was something i was doubtful about
go-scm/scm/driver/github/pr.go
Line 169 in ecd9254
In github they do this https://docs.github.com/en/webhooks/webhook-events-and-payloads?actionType=opened#pull_request
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.