Skip to content

Change Duck.ai auto-submit behavior #5980

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 5, 2025

Conversation

joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Apr 29, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1210096722341714?focus=true

Description

  • While on SERP, if the user is not currently typing in the address bar, tapping the Duck.ai button will pre-fill the query in Duck.ai. The user will then need to tap the submit button.
  • If the user is typing, then the prompt will auto-submit.
  • If the user opens Duck.ai while the current URL is in the address bar then Duck.ai is opened without a prompt.

Steps to test this PR

  • On new tab, tap the Duck.ai button
  • Verify that Duck.ai is opened without a prompt
  • Go back
  • Type something and tap the Duck.ai button
  • Verify that Duck.ai is opened with auto-prompt
  • Go back and submit the query
  • Tap the address bar and then the Duck.ai button
  • Verify that the prompt is pre-filled
  • Go back
  • Edit the query and tap the Duck.ai button
  • Verify that Duck.ai is opened with auto-prompt
  • Kill the app and reopen
  • Tap the address bar and then the Duck.ai button
  • Verify that the prompt is pre-filled

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joshliebe joshliebe force-pushed the feature/josh/duck-ai-auto-submit-behavior branch from a35cfd8 to 3583ff8 Compare May 2, 2025 12:40
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. LGTM

@joshliebe joshliebe merged commit e4c7efc into develop May 5, 2025
7 checks passed
@joshliebe joshliebe deleted the feature/josh/duck-ai-auto-submit-behavior branch May 5, 2025 14:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants