Fix: NTP creation crash with tab swiping #6007
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1210095537840719?focus=true
Description
This PR fixes the NTP creation. There was a logical error in the previous implementation when the wrong boolean was being returned in
transformWhile()when requesting a new tab, which in some situation might result in the flow completion without emitting any value, which resulted in a crash.I added code that throws an exception when a new tab is not created because it's an invalid state in the DB that I'm not sure how we should recover from. I don't think that's what was happening but in case it does, we'll know where to start looking.
Steps to test this PR
I wasn't able to reproduce it, however, I added unit tests that should verify the fix works as expected.