Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Xiangzhou/fix issue make post request #15

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

xiangzho72
Copy link

  1. Fix the error when calling make_post_request() by following suggestion from : https://stackoverflow.com/questions/13175253/python-error-type-error-post-data-should-be-bytes-also-user-agent-issue

  2. Change iomessage::contextdata and contentdata from type 'bytearray' to 'string', otherwise, user has to use following :
    msg.contentdata = bytearray('hello world'.encode()),
    Rather than the more intuitive way below:
    msg.contentdata = 'hello world'

    my thought is those two fields should be like other fields in iomessage: string when processing, and transformed to bytearray just before sending to wire

  3. Updated broken test cases. I have verified them in my local environment.

The change is branched from tag v2.0.1

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants