-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Xiangzhou/fix issue make post request #15
Open
xiangzho72
wants to merge
32
commits into
eclipse-iofog:master
Choose a base branch
from
xiangzho72:xiangzhou/fix_issue_make_post_request
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Xiangzhou/fix issue make post request #15
xiangzho72
wants to merge
32
commits into
eclipse-iofog:master
from
xiangzho72:xiangzhou/fix_issue_make_post_request
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python SDK Updates for 1.3.0
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the error when calling make_post_request() by following suggestion from : https://stackoverflow.com/questions/13175253/python-error-type-error-post-data-should-be-bytes-also-user-agent-issue
Change iomessage::contextdata and contentdata from type 'bytearray' to 'string', otherwise, user has to use following :
msg.contentdata = bytearray('hello world'.encode()),
Rather than the more intuitive way below:
msg.contentdata = 'hello world'
my thought is those two fields should be like other fields in iomessage: string when processing, and transformed to bytearray just before sending to wire
Updated broken test cases. I have verified them in my local environment.
The change is branched from tag v2.0.1