Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

sa #247

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

sa #247

wants to merge 4 commits into from

Conversation

sreysa
Copy link

@sreysa sreysa commented Feb 13, 2019

i dun want to say anything about it , it is so hard.

@codecov-io
Copy link

Codecov Report

Merging #247 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #247   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          94     94           
  Lines         454    454           
=====================================
  Hits          454    454

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d00b122...4a263a7. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #247 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #247   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          94     95    +1     
  Lines         454    465   +11     
=====================================
+ Hits          454    465   +11
Impacted Files Coverage Δ
src/armstrong.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d00b122...0a5994b. Read the comment docs.

@sidag95
Copy link

sidag95 commented Feb 14, 2019

@sreysa Seems like you have added a bunch of c files. I am afraid this particular repo is only for javascript functions and thus this PR might not be acceptable (right @kentcdodds ?)
Side Note:
Before raising a PR, try and remove all the redundant code that you have commented out just so that the code base is clean

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants