-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[8.x] Upgrade EUI to v101.1.0-classic.0 #216208
base: 8.x
Are you sure you want to change the base?
Conversation
- mono prop was removed from the component as the component only supports the mono/grey-scale version now
- it will be enabled once Kibana has implemented the required UI for it
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
Historycc @mgadewoll |
Cloud deployment initiated, see credentials at: https://buildkite.com/elastic/kibana-deploy-cloud-from-pr/builds/121 |
Pinging @elastic/eui-team (EUI) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
Important
This PR is the direct, manual backport to
8.x
for this PR that's being merged tomain
.The reason it's handled manually is that
8.x
receives a custom EUI release that still has the "Amsterdam" theme as default theme enabled.100.0.0
⏩101.1.0
Questions? Please see our Kibana upgrade FAQ.
Package updates
@elastic/eui
v101.1.0
EuiTableRow
styles to check support for:has(+)
selector (#8498)@elastic/eui
v101.0.1
EuiProvider
andEuiThemeProvider
with a newhighContrastMode
(#8444)EuiProvider
, if thehighContrastMode
prop is not passed, this setting will inherit from the user's OS/system settingshighContrastMode
orcolorMode
props passedhighContrastModeStyles
andpreventForcedColors
styling utils (#8444)EuiRangeTooltip
to be easier to see in dark mode (#8444)text
->textParagraph
title
->textHeading
subduedText
->textSubdued
disabledText
->textDisabled
accentText
->textAccent
dangerText
->textDanger
warningText
->textWarning
useEuiShadow()
now accepts a secondoptions
argument (#8234)useEuiShadowFlat()
now accepts anoptions
object instead of only a color (#8234)EuiPopover
andEuiToolTip
to be easier to see in dark mode. (#8174)Bug fixes
Fixed a visual bug where a transparent border would create visible empty space (
LIGHT
mode only) for the components: (#8427)EuiPanel
EuiPopover
EuiToolTip
EuiToast
EuiTour
@elastic/eui-theme-common
v0.1.0
Removed type
EuiShadowCustomColor
(#8444)Added types: (#8444)
EuiShadowOptions
EuiThemeHighContrastModeProp
EuiThemeHighContrastMode
Updated shadow utils to accepts a second
options
argument and return borders in high contrast mode: (#8444)euiShadow
euiShadowXSmall
euiShadowSmall
euiShadowMedium
euiShadowLarge
euiSlightShadowHover
euiShadowFlat
@elastic/eui-theme-borealis
v0.1.0
buttonGroupBackgroundDisabledSelected
overlayMaskBackground
overlayMaskBackgroundHighContrast
skeletonBackgroundSkeletonMiddleHighContrast
Additional changes
The latest
@elastic/eui
package introduces high contrast mode support. This PR sets the rootEuiProvider
to usehighContrastMode={false}
to introduce it in disabled state (this reflects the current functionality in Kibana).Cloud-UI can enable this whenever it's tested and supported from their end.
QA
Adding high contrast mode in disabled state should result in no visual changes to the UI.