Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[8.x] Upgrade EUI to v101.1.0-classic.0 #216208

Open
wants to merge 4 commits into
base: 8.x
Choose a base branch
from

Conversation

mgadewoll
Copy link
Contributor

Important

This PR is the direct, manual backport to 8.x for this PR that's being merged to main.
The reason it's handled manually is that 8.x receives a custom EUI release that still has the "Amsterdam" theme as default theme enabled.


100.0.0101.1.0

Questions? Please see our Kibana upgrade FAQ.

Package updates

@elastic/eui v101.1.0

  • Updates EuiTableRow styles to check support for :has(+) selector (#8498)

@elastic/eui v101.0.1

  • Updated EuiProvider and EuiThemeProvider with a new highContrastMode (#8444)
    • This prop allows toggling a higher contrast visual style that primarily affects borders and shadows
    • On EuiProvider, if the highContrastMode prop is not passed, this setting will inherit from the user's OS/system settings
    • If the user is using a forced colors mode (e.g. Windows' high contrast themes), this system setting will take precedence over any highContrastMode or colorMode props passed
  • Added highContrastModeStyles and preventForcedColors styling utils (#8444)
  • Updated EuiRangeTooltip to be easier to see in dark mode (#8444)
  • Updated some deprecated color token usages that have direct substitutes (#8444)
    • text -> textParagraph
    • title -> textHeading
    • subduedText -> textSubdued
    • disabledText -> textDisabled
    • accentText -> textAccent
    • dangerText -> textDanger
    • warningText -> textWarning
  • useEuiShadow() now accepts a second options argument (#8234)
  • useEuiShadowFlat() now accepts an options object instead of only a color (#8234)
  • Updated EuiPopover and EuiToolTip to be easier to see in dark mode. (#8174)

Bug fixes

  • Fixed a visual bug where a transparent border would create visible empty space (LIGHT mode only) for the components: (#8427)

    • EuiPanel
    • EuiPopover
    • EuiToolTip
    • EuiToast
    • EuiTour

@elastic/eui-theme-common v0.1.0

  • Removed type EuiShadowCustomColor (#8444)

  • Added types: (#8444)

    • EuiShadowOptions
    • EuiThemeHighContrastModeProp
    • EuiThemeHighContrastMode
  • Updated shadow utils to accepts a second options argument and return borders in high contrast mode: (#8444)

    • euiShadow
    • euiShadowXSmall
    • euiShadowSmall
    • euiShadowMedium
    • euiShadowLarge
    • euiSlightShadowHover
    • euiShadowFlat

@elastic/eui-theme-borealis v0.1.0

  • Added new component level tokens: (#8444)
    • buttonGroupBackgroundDisabledSelected
    • overlayMaskBackground
    • overlayMaskBackgroundHighContrast
    • skeletonBackgroundSkeletonMiddleHighContrast

Additional changes

The latest @elastic/eui package introduces high contrast mode support. This PR sets the root EuiProvider to use highContrastMode={false} to introduce it in disabled state (this reflects the current functionality in Kibana).
Cloud-UI can enable this whenever it's tested and supported from their end.

QA

Adding high contrast mode in disabled state should result in no visual changes to the UI.

- mono prop was removed from the component as the component only supports the mono/grey-scale version now
- it will be enabled once Kibana has implemented the required UI for it
@mgadewoll mgadewoll added backport EUI ci:cloud-deploy Create or update a Cloud deployment v8.19.0 labels Mar 27, 2025
@mgadewoll mgadewoll self-assigned this Mar 27, 2025
@mgadewoll mgadewoll requested review from a team and jkelas and removed request for a team March 27, 2025 16:38
@mgadewoll mgadewoll requested review from a team, pzl and tomsonpl and removed request for a team March 27, 2025 16:43
@elasticmachine
Copy link
Contributor

elasticmachine commented Mar 27, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
controls 366 368 +2
dashboard 667 669 +2
infra 1750 1753 +3
kubernetesSecurity 191 193 +2
maps 1278 1280 +2
ml 2440 2443 +3
visTypeVega 551 554 +3
total +17

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 451.8KB 451.8KB -5.0B
apm 2.6MB 2.6MB -5.0B
controls 471.6KB 478.4KB +6.8KB
dashboard 602.6KB 608.8KB +6.2KB
datasetQuality 241.6KB 241.6KB -13.0B
infra 1.6MB 1.6MB +8.3KB
kubernetesSecurity 256.9KB 263.1KB +6.2KB
maps 3.1MB 3.1MB +6.2KB
ml 5.4MB 5.4MB +8.2KB
profiling 400.9KB 400.9KB -22.0B
securitySolution 9.1MB 9.1MB -8.0B
slo 918.6KB 918.6KB -48.0B
synthetics 1.1MB 1.1MB -8.0B
ux 168.8KB 168.8KB -16.0B
visTypeTimeseries 475.8KB 475.8KB -16.0B
visTypeVega 2.0MB 2.0MB +8.3KB
visualizations 347.7KB 347.7KB -16.0B
total +50.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressions 92.2KB 92.1KB -8.0B
kbnUiSharedDeps-npmDll 5.9MB 5.9MB +31.3KB
kbnUiSharedDeps-srcJs 3.6MB 3.6MB +20.0B
presentationPanel 10.9KB 10.9KB -8.0B
visDefaultEditor 20.8KB 20.8KB -8.0B
visualizations 35.2KB 35.2KB -8.0B
total +31.3KB

History

cc @mgadewoll

@kibanamachine
Copy link
Contributor

Cloud deployment initiated, see credentials at: https://buildkite.com/elastic/kibana-deploy-cloud-from-pr/builds/121

@mgadewoll mgadewoll marked this pull request as ready for review March 28, 2025 09:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Mar 28, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
backport ci:cloud-deploy Create or update a Cloud deployment EUI Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team v8.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants