Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add run from ASAR button #1695

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlokYadavCodes
Copy link
Contributor

  • Adds a dropdown to the right of the "Run" button, featuring a new button labeled "Run from ASAR"
  • Introduces a new optional parameter runOptions in Runner.run() method.
  • The runOptions parameter is defined as follows:
interface runOptions {
  runFromAsar: boolean;
}
  • Updates test snapshots to reflect the new UI changes.

Updated UI screenshots:

Screenshot from 2025-03-20 23-48-01
Screenshot from 2025-03-20 23-48-16

Closes #1551

This functionality requires an upstream change in @electron/fiddle-core.

I have already opened a PR to implement the required updates in fiddle-core:

Please review both the PR's and let me know if any changes are needed.

@AlokYadavCodes AlokYadavCodes requested review from codebytere and a team as code owners March 20, 2025 19:18
@AlokYadavCodes
Copy link
Contributor Author

Hey @codebytere , just checking in. Let me know if there's anything I can do to help with the review.

Also tagging @dsanders11 , since you opened this issue and are mentoring the GSoC project I’m applying for (Fiddle Support for Fuses), I would love to hear your thoughts as well.

Thanks so much for your time and guidance. I really appreciate it and am excited to incorporate any feedback you might have!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run from ASAR
1 participant