Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
globally_*
variables were being overridden in thefor f in forum
loop, which screwed them up for the next iteration.TL;DR: If your forums were ordered [public1, private, public2] it worked, public2 wasn't visible, because its permission check ran after the check for private. This fix simply renames the variables so nothing inside one loop iteration influences the next iteration.
For example:
globally_granted_group_perms = ["can_see_forum", "can_read_forum"]
)globally_nongranted_group_perms = ["can_see_forum", "can_read_forum"]
)globally_granted_group_perms
gets filtered to= []
globally_granted_group_perms = []
is the starting point, so no permissions are returnedThe test I added failed before the fix, now it passes.