Skip to content
This repository was archived by the owner on May 3, 2022. It is now read-only.

Conversation

ydv-sahitya
Copy link

@ydv-sahitya ydv-sahitya commented Apr 10, 2022

πŸ› οΈ Fixes Issue

πŸ‘¨β€πŸ’» Changes proposed

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

πŸ“· Screenshots

@ydv-sahitya ydv-sahitya requested a review from nickvidal as a code owner April 10, 2022 08:19
@ydv-sahitya ydv-sahitya changed the title updated the path updated the path (WebAssembly with Rust doc) Apr 10, 2022
@ydv-sahitya
Copy link
Author

please review this.

@ydv-sahitya
Copy link
Author

image

@rjzak
Copy link
Contributor

rjzak commented Apr 10, 2022

To build a release version, you'd run cargo build --release.

@ydv-sahitya
Copy link
Author

ydv-sahitya commented Apr 10, 2022

To build a release version, you'd run cargo build --release.

so when I was following docs, where it mentioned cargo build only from that I was not getting release path. should I change cargo build to cargo build --release in docs?

@rjzak
Copy link
Contributor

rjzak commented Apr 10, 2022

Is this the page: https://enarx.dev/docs/WebAssembly/Rust ? The screenshot does show using cargo build --release

@ydv-sahitya
Copy link
Author

ydv-sahitya commented Apr 10, 2022

Is this the page: https://enarx.dev/docs/WebAssembly/Rust ? The screenshot does show using cargo build --release

yes, my bad, you are right, I did not read the screenshot. should I add release in this cargo build --target=wasm32-wasi. or I should not? or should I leave it the way it is. thank you.

@rjzak
Copy link
Contributor

rjzak commented Apr 10, 2022

No worries :)
My guess is to leave it as-is, but I'm also not the maintainer.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants