Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add tooltip code details #291

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

dylanmccall
Copy link
Contributor

Just idly playing with tooltips here. Let me know what you think?

Some nice examples:

Screenshot From 2024-10-24 21-01-40

Screenshot From 2024-10-24 21-01-55

Screenshot From 2024-10-24 21-08-39

Screenshot From 2024-10-24 21-02-15

Screenshot From 2024-10-24 21-02-42

Some more suspect examples:

Screenshot From 2024-10-24 21-03-12

Screenshot From 2024-10-24 21-04-32

I was hoping I could improve the formatting here with some divider lines, which would especially help when we have both parameters and an output value, but Godot's bbcode implementation doesn't seem to support [hr], so we'd have to do a whole other thing with the custom tooltip scene (and that whole thing should really involve adding syntax highlighting anyway).

@dylanmccall dylanmccall force-pushed the add-tooltip-code-details branch from e5d2cef to 6958eb3 Compare October 25, 2024 04:13
Copy link
Contributor

@starnight starnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This looks amazing!

Copy link
Member

@dbnicholson dbnicholson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty sweet to me! @wjt you poked at tooltips and bbcode before. WDYT?

@DoomTas3r
Copy link
Contributor

Another interesting example:
capture

@wjt
Copy link
Member

wjt commented Oct 25, 2024

Personally I think this is too much information. I would want to get e.g. Justin's opinion as an educator.

@DoomTas3r
Copy link
Contributor

Maybe the tooltip could include the minimum information and an option in the context menu would have the full summary
capture

@manuq manuq marked this pull request as draft October 30, 2024 12:32
@manuq
Copy link
Contributor

manuq commented Oct 30, 2024

Converting to Draft until we get feedback from Justin or any other educator.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants