Make the compile time parameter error clearer #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print out the expectation that the parameter should be under a specific key.
orien
reviewed
Feb 2, 2021
| @@ -23,7 +23,7 @@ def has_invalid_values? | |||
| end | |||
|
|
|||
| def create_error | |||
| "#{@name} cannot contain empty parameters:#{@parameter.inspect}" | |||
| "#{@name} is not present inside the 'compile_time_parameters' entry, or has an empty value; found: #{@parameter.inspect}" | |||
There was a problem hiding this comment.
I think we should inform that it's a parameter that's missing. Can sort of infer it from the compile_time_parameters name, but better to be explicit.
orien
approved these changes
Dec 29, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print out the expectation that the parameter should be under a specific key.