Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add logging overriding #36

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

07pepa
Copy link

@07pepa 07pepa commented Jun 18, 2024

sometimes its nice to have your custom logging in fastapi so i added passing it to uvicorn and fallbacking to uvicorn default one if nothing is passed in

@07pepa 07pepa marked this pull request as draft June 18, 2024 16:11
@07pepa 07pepa force-pushed the add-log-config-overides branch from 9f35763 to 457b390 Compare June 19, 2024 07:47
@07pepa 07pepa marked this pull request as ready for review June 19, 2024 07:48
@Leon0824
Copy link

+1

2 similar comments
@FelixBehne
Copy link

+1

@wchaws
Copy link

wchaws commented Jul 29, 2024

+1

@saligrama
Copy link

+1

@07pepa 07pepa force-pushed the add-log-config-overides branch from 457b390 to 5ad2af6 Compare August 19, 2024 14:10
@07pepa
Copy link
Author

07pepa commented Aug 19, 2024

@wchaws can you please add tag feature to fix failing test? thanks

@wchaws
Copy link

wchaws commented Aug 20, 2024

@07pepa I'm not the maintainer for this project. I just accidentally approved this PR.

@07pepa
Copy link
Author

07pepa commented Aug 20, 2024

ok i thought you would have some extra rights if you could approve

patrick91 added a commit to patrick91/fastapi-cli that referenced this pull request Sep 23, 2024
…_existing_app

✨ Allow to use an existing app
@07pepa 07pepa force-pushed the add-log-config-overides branch from 5ad2af6 to fce4d85 Compare September 24, 2024 16:07
@dineshnauti
Copy link

+1

@jrs53
Copy link

jrs53 commented Oct 22, 2024

Is this PR just missing label "feature"? @07pepa @wchaws Are you able to add it?

Thanks

@07pepa 07pepa force-pushed the add-log-config-overides branch from fce4d85 to 14cb9ad Compare October 22, 2024 11:27
@07pepa
Copy link
Author

07pepa commented Oct 22, 2024

Is this PR just missing label "feature"? @07pepa @wchaws Are you able to add it?

Thanks

Yes i am unable as author of PR to change/add label. Label is only thing that is missing.

i tried even modifying labeler and no luck #110

we probably need to ask @tiangolo how to do this (or to add label)

@vitaliy-sk
Copy link

+1

@mapapa
Copy link

mapapa commented Jan 2, 2025

Hihi all, is anybody looking into fixing the labeler issue? Thanks

@07pepa 07pepa force-pushed the add-log-config-overides branch from 14cb9ad to 0961863 Compare January 4, 2025 23:19
@07pepa
Copy link
Author

07pepa commented Jan 10, 2025

@mapapa i can't

@LoopKarma
Copy link

Can you please help this feature to go through @tiangolo? it's very annoying to see unnecessary access logs in production servers

@darowny
Copy link

darowny commented Feb 6, 2025

+1 I need ECS logging for fastapi run

@darowny
Copy link

darowny commented Mar 25, 2025

Any updates here ? Could I take over if I need this functionality ? What is the problem with labels ?

@07pepa
Copy link
Author

07pepa commented Mar 25, 2025

Any updates here ? Could I take over if I need this functionality ? What is the problem with labels ?

this is problem with labes
https://github.com/fastapi/fastapi-cli/actions/runs/13716548094/job/38362509674?pr=36

also problem here #160
probably we need acces to repo to add labels

@07pepa
Copy link
Author

07pepa commented Mar 25, 2025

@darowny you can take over

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.