GitHub: Created a build script for CI/CD #16899
Open
+154
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x5bfa
changed the title
0x5bfa
force-pushed
the
5bfa/GH-RefactorCD
branch
from
c1adfa8 to
258e1ba
Compare
0x5bfa
force-pushed
the
5bfa/GH-RefactorCD
branch
from
258e1ba to
0c8efc2
Compare
Lamparter
reviewed
Mar 8, 2025
Comment on lines
-215
to
+202
| - name: Install Files | ||
| - name: Prepare for the tests | ||
| shell: powershell | ||
| run: | | ||
| Set-Location "$env:APPX_PACKAGE_DIR" | ||
| $AppxPackageBundleDir = Get-ChildItem -Filter Files.Package_*_Test -Name | ||
| Set-Location $AppxPackageBundleDir | ||
| ./Install.ps1 -Force | ||
| Get-AppxPackage | ||
|
|
||
| - name: Set full HD resolution | ||
| run: Set-DisplayResolution -Width 1920 -Height 1080 -Force | ||
|
|
||
| - name: Start WinAppDriver process | ||
| shell: pwsh | ||
| run: Start-Process -FilePath "$env:WINAPPDRIVER_EXE86_PATH" | ||
| Set-DisplayResolution -Width 1920 -Height 1080 -Force | ||
| Start-Process -FilePath "$env:WINAPPDRIVER_EXE86_PATH" |
There was a problem hiding this comment.
Why did you merge these into one step?
There was a problem hiding this comment.
Because I thought they hardly would fail and merging them would not harm us, rather, it contributes to having less lines of code.
yaira2
force-pushed
the
main
branch
7 times, most recently
from
30cea65 to
decf3da
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes