Skip to content

Smarter field state management during insert and remove #29

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jul 12, 2019

Conversation

erikras
Copy link
Member

@erikras erikras commented Jul 12, 2019

This should fix a whole slew of bugs mentioned in final-form/react-final-form-arrays#66.

@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #29   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines         101    120   +19     
  Branches       19     22    +3     
=====================================
+ Hits          101    120   +19
Impacted Files Coverage Δ
src/shift.js 100% <100%> (ø) ⬆️
src/unshift.js 100% <100%> (ø) ⬆️
src/insert.js 100% <100%> (ø) ⬆️
src/remove.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9345846...3a9566a. Read the comment docs.

@erikras erikras merged commit b197a58 into master Jul 12, 2019
@erikras erikras deleted the fix-insert-remove-bugs branch July 12, 2019 16:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2025
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant