Removed deprecated public constructor KeyValueBuilder #6924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/crashlytics/KeyValueBuilder.html 2025-04-30 20:59:47.901144582 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/crashlytics/KeyValueBuilder.html 2025-04-30 20:57:18.832816678 +0000
@@ -21,27 +21,6 @@
</colgroup>
<thead>
<tr>
- <th colspan="100%"><h3>Public constructors</h3></th>
- </tr>
- </thead>
- <tbody class="list">
- <tr>
- <td>
- <div><code><span><del><a href="/docs/reference/android/com/google/firebase/crashlytics/KeyValueBuilder.html#KeyValueBuilder(com.google.firebase.crashlytics.FirebaseCrashlytics)">KeyValueBuilder</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html">FirebaseCrashlytics</a> crashlytics)</code></div>
- <p><strong>This method is deprecated.</strong> Do not construct this directly.</p>
- </td>
- </tr>
- </tbody>
- </table>
- </div>
- <div class="devsite-table-wrapper">
- <table class="responsive">
- <colgroup>
- <col width="40%">
- <col>
- </colgroup>
- <thead>
- <tr>
<th colspan="100%"><h3>Public methods</h3></th>
</tr>
</thead>
@@ -92,14 +71,6 @@
</table>
</div>
<div class="list">
- <h2>Public constructors</h2>
- <div class="api-item"><a name="KeyValueBuilder-com.google.firebase.crashlytics.FirebaseCrashlytics-"></a><a name="keyvaluebuilder"></a>
- <h3 class="api-name" id="KeyValueBuilder(com.google.firebase.crashlytics.FirebaseCrashlytics)">KeyValueBuilder</h3>
- <pre class="api-signature no-pretty-print">public <span><del><a href="/docs/reference/android/com/google/firebase/crashlytics/KeyValueBuilder.html#KeyValueBuilder(com.google.firebase.crashlytics.FirebaseCrashlytics)">KeyValueBuilder</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/crashlytics/FirebaseCrashlytics.html">FirebaseCrashlytics</a> crashlytics)</pre>
- <aside class="caution"><strong>This method is deprecated.</strong><br>Do not construct this directly. Use `setCustomKeys` instead. To be removed in the next major release.</aside>
- </div>
- </div>
- <div class="list">
<h2>Public methods</h2>
<div class="api-item"><a name="key(kotlin.String, kotlin.Boolean)"></a><a name="key-kotlin.String-kotlin.Boolean-"></a><a name="key"></a>
<h3 class="api-name" id="key(kotlin.String,kotlin.Boolean)">key</h3>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/crashlytics/KeyValueBuilder.html 2025-04-30 20:59:47.899144590 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/crashlytics/KeyValueBuilder.html 2025-04-30 20:57:18.819816741 +0000
@@ -21,27 +21,6 @@
</colgroup>
<thead>
<tr>
- <th colspan="100%"><h3>Public constructors</h3></th>
- </tr>
- </thead>
- <tbody class="list">
- <tr>
- <td>
- <div><code><span><del><a href="/docs/reference/kotlin/com/google/firebase/crashlytics/KeyValueBuilder.html#KeyValueBuilder(com.google.firebase.crashlytics.FirebaseCrashlytics)">KeyValueBuilder</a></del></span>(crashlytics: <a href="/docs/reference/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html">FirebaseCrashlytics</a>)</code></div>
- <p><strong>This function is deprecated.</strong> Do not construct this directly.</p>
- </td>
- </tr>
- </tbody>
- </table>
- </div>
- <div class="devsite-table-wrapper">
- <table class="responsive">
- <colgroup>
- <col width="40%">
- <col>
- </colgroup>
- <thead>
- <tr>
<th colspan="100%"><h3>Public functions</h3></th>
</tr>
</thead>
@@ -92,14 +71,6 @@
</table>
</div>
<div class="list">
- <h2>Public constructors</h2>
- <div class="api-item"><a name="KeyValueBuilder-com.google.firebase.crashlytics.FirebaseCrashlytics-"></a><a name="keyvaluebuilder"></a>
- <h3 class="api-name" id="KeyValueBuilder(com.google.firebase.crashlytics.FirebaseCrashlytics)">KeyValueBuilder</h3>
- <pre class="api-signature no-pretty-print"><span><del><a href="/docs/reference/kotlin/com/google/firebase/crashlytics/KeyValueBuilder.html#KeyValueBuilder(com.google.firebase.crashlytics.FirebaseCrashlytics)">KeyValueBuilder</a></del></span>(crashlytics: <a href="/docs/reference/kotlin/com/google/firebase/crashlytics/FirebaseCrashlytics.html">FirebaseCrashlytics</a>)</pre>
- <aside class="caution"><strong>This function is deprecated.</strong><br>Do not construct this directly. Use `setCustomKeys` instead. To be removed in the next major release.</aside>
- </div>
- </div>
- <div class="list">
<h2>Public functions</h2>
<div class="api-item"><a name="key(kotlin.String, kotlin.Boolean)"></a><a name="key-kotlin.String-kotlin.Boolean-"></a><a name="key"></a>
<h3 class="api-name" id="key(kotlin.String,kotlin.Boolean)">key</h3> |
Vertex AI Mock Responses Check
|
mrober
approved these changes
Apr 30, 2025
Coverage Report 1Affected ProductsTest Logs |
|
The public api surface has changed for the subproject firebase-crashlytics: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
themiswang
force-pushed
the
deprecationKeyValue
branch
from
ef60d63 to
1892a2d
Compare
themiswang
force-pushed
the
deprecationKeyValue
branch
from
1892a2d to
eb1bb02
Compare
|
The public api surface has changed for the subproject firebase-crashlytics: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
themiswang
force-pushed
the
deprecationKeyValue
branch
from
eb1bb02 to
19d9fed
Compare
Test Results 8 files - 14 8 suites - 14 20s ⏱️ +6s Results for commit 19d9fed. ± Comparison against base commit 2b23887. This pull request removes 98 and adds 22 tests. Note that renamed tests count towards both. |
Size Report 1Affected Products
Test Logs |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
rlazo
requested changes
May 1, 2025
kaibolay
approved these changes
May 7, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prepare for next major bump
Original change:#6536