Skip to content

Add a unit test to verify behavior w/ URLSession:dataTask:didReceiveResponse:completionHandler: #14489

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

tejasd
Copy link
Contributor

@tejasd tejasd commented Feb 24, 2025

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@@ -62,6 +62,35 @@ - (void)forwardInvocation:(NSInvocation *)invocation {

@end

@interface FPRNSURLSessionDelegateProxy : NSProxy <NSURLSessionDelegate> {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try re-running the tests with:

Suggested change
@interface FPRNSURLSessionDelegateProxy : NSProxy <NSURLSessionDelegate> {
@interface FPRNSURLSessionDelegateProxy : NSProxy {

@tejasd tejasd requested a review from visumickey March 4, 2025 20:27
@tejasd tejasd marked this pull request as draft March 10, 2025 18:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants