Skip to content

[Vertex AI] Enable AccessLevelOnImport and InternalImportsByDefault #14639

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Apr 1, 2025

WIP - Blocked on #14627 and #14638

Enabled the experimental (in Swift 5.x) feature AccessLevelOnImport and the upcoming opt-in feature InternalImportsByDefault for the Vertex AI SDK. AccessLevelOnImport will be the default in Swift 6.x and can be removed once #14627 and #14638 have been completed.

This PR starts resolving #13031 by removing uses of @_implementationOnly in the FirebaseVertexAI target.

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@paulb777
Copy link
Member

Is this PR still relevant?

@ncooke3
Copy link
Member

ncooke3 commented Apr 10, 2025

Yes, but the Package.swift changes can wait for Firebase 12. And internal could explicitly be added to imports for now.

@andrewheard
Copy link
Contributor Author

Yes, but the Package.swift changes can wait for Firebase 12. And internal could explicitly be added to imports for now.

@ncooke3 @paulb777 If I can do it quickly, I'd like to see if I can continue to use InternalImportsByDefault (removed AccessLevelOnImport though). I'd be more comfortable that I haven't missed something and unintentionally made it public.

@ncooke3 ncooke3 force-pushed the ah/vertex-imports branch from 8b2454f to 1624478 Compare April 11, 2025 20:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants