-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[Vertex AI] Enable AccessLevelOnImport
and InternalImportsByDefault
#14639
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
Is this PR still relevant? |
Yes, but the |
@ncooke3 @paulb777 If I can do it quickly, I'd like to see if I can continue to use |
8b2454f
to
1624478
Compare
WIP - Blocked on #14627 and #14638
Enabled the experimental (in Swift 5.x) feature
AccessLevelOnImport
and the upcoming opt-in featureInternalImportsByDefault
for the Vertex AI SDK.AccessLevelOnImport
will be the default in Swift 6.x and can be removed once #14627 and #14638 have been completed.This PR starts resolving #13031 by removing uses of
@_implementationOnly
in theFirebaseVertexAI
target.#no-changelog