-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Use new Google Utility for detecting whether to support background URL session uploads #14794
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
cc @aerickson14 who hit this specific issue in his App Clip |
…L session uploads
c92e296
to
1470f4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bumping the dependency versions!
It seems that crashlytics test might be flaky... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a Changelog update.
Thanks! |
This adopts a new GoogleUtilities API I am adding here: google/GoogleUtilities#220
This will properly force App Clips to fall back to foreground uploads, since background uploads are not supported. Essentially, this expands the heuristic that was previously looking for app extensions.
Fixes #14793