Skip to content

Use new Google Utility for detecting whether to support background URL session uploads #14794

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 2, 2025

Conversation

harlanhaskins
Copy link
Contributor

@harlanhaskins harlanhaskins commented Apr 30, 2025

This adopts a new GoogleUtilities API I am adding here: google/GoogleUtilities#220

This will properly force App Clips to fall back to foreground uploads, since background uploads are not supported. Essentially, this expands the heuristic that was previously looking for app extensions.

Fixes #14793

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@harlanhaskins
Copy link
Contributor Author

cc @aerickson14 who hit this specific issue in his App Clip

@ncooke3 ncooke3 self-assigned this May 1, 2025
@harlanhaskins harlanhaskins force-pushed the harlan/hi-im-clippy branch from c92e296 to 1470f4e Compare May 1, 2025 19:52
Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the dependency versions!

@harlanhaskins
Copy link
Contributor Author

It seems that crashlytics test might be flaky...

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a Changelog update.

@ncooke3
Copy link
Member

ncooke3 commented May 2, 2025

Thanks!

@ncooke3 ncooke3 merged commit 38c0f83 into firebase:main May 2, 2025
414 of 415 checks passed
@harlanhaskins harlanhaskins deleted the harlan/hi-im-clippy branch May 2, 2025 19:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

putFile tries to perform background file uploads in app clip processes, which fails
3 participants