Add PauseVM and ResumeVM support #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plamenmpetrov
force-pushed
the
pause_resume
branch
2 times, most recently
from
2fdd111 to
cfa6dcc
Compare
|
Looks good to me! Can you add an integration test that pauses and resumes a VM? |
ustiugov
force-pushed
the
pause_resume
branch
from
cfa6dcc to
2ac4770
Compare
|
it seems that the buildkite failure is not related to the patch. how can I re-run the test? |
|
Let me take a look. Right now only maintainers can restart tests. |
kzys
suggested changes
Jan 20, 2021
ustiugov
force-pushed
the
pause_resume
branch
2 times, most recently
from
593dc36 to
0508a7b
Compare
|
@kzys we added the necessary tests, could you please take another look? |
|
Looks good to me. I think the build errors are related to #475, not your changes. |
|
I've merged #475. Can you rebase this PR against master? This should fix GitHub Actions failures at least. |
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
Signed-off-by: Dmitrii Ustiugov <dmitrii.ustiugov@ed.ac.uk>
ustiugov
force-pushed
the
pause_resume
branch
from
e382a9c to
fad2ed3
Compare
Signed-off-by: Plamen Petrov <plamb0brt@gmail.com>
ustiugov
force-pushed
the
pause_resume
branch
from
fad2ed3 to
9e76ba0
Compare
kzys
approved these changes
Feb 19, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to implement support for PauseVM and ResumeVM.
Authored by @plamenmpetrov and @ustiugov
We are open to feedback and would be glad to finalize and contribute this code to upstream.
Issue #, if available:
#448
Description of changes:
tc-redirect-tap, which is no longer part of the Go SDKBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.