Skip to content

Upgrade firecracker from v1.1.0 to v.1.4.1 #768

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Kern--
Copy link
Contributor

@Kern-- Kern-- commented Sep 22, 2023

Issue #, if available:

Description of changes:
carry of #757

Upgrade firecracker from v1.1.0 to v.1.4.1

Firecracker diff firecracker-microvm/firecracker@v1.1.0...v1.4.1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

fangn2 and others added 2 commits September 22, 2023 21:04
Update firecracker-go-sdk dependency

Remove devtool strip which has been removed in latest firecracker release

Signed-off-by: Tony Fang <nhfang@amazon.com>
Before the change, we relied on Firecracker's devtool to build a custom
kernel with our configs (which add FUSE support). The devtool's
build_kernel function is broken in Firecracker 1.4.1 and is completely
replaced by a non-containerized build script in main.

Rather than trying to get Firecracker's internal dev tooling to work for
our purposes, this change takes just the necessary scripts from
Firecracker to build a kernel in a container.

Signed-off-by: Kern Walster <walster@amazon.com>
@Kern-- Kern-- requested a review from a team as a code owner September 22, 2023 21:09
Signed-off-by: Kern Walster <walster@amazon.com>
For some reason, waiting for the task exit before waiting for the
rngtest outside the container causes rngtest's stdin to block forever.

Signed-off-by: Kern Walster <walster@amazon.com>
@swagatbora90
Copy link
Contributor

@Kern-- PR needs a rebase.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants