Vasily/refinement_region_clean #2398
Conversation
| @@ -126,6 +216,12 @@ class DistanceUnstructuredGrid(UnstructuredGrid): | |||
| "``dl_bulk`` is used instead.", | |||
| ) | |||
|
|
|||
| mesh_refinements: Tuple[Union[GridRefinementRegion, GridRefinementLine], ...] = pd.Field( | |||
There was a problem hiding this comment.
does this cause any sporadic error messages? We typically need to add annotate_type in such situations like here https://github.com/flexcompute/tidy3d/blob/develop/tidy3d/components/simulation.py#L2289, otherwise pydantic would loop through all allowed classes when initializing this field and some of which fail and show an error message
There was a problem hiding this comment.
I can create a special type for Union[GridRefinementRegion, GridRefinementLine] like it is done in other places, if it is better.
There was a problem hiding this comment.
no need for that, just meant to wrap Union[GridRefinementRegion, GridRefinementLine] into annotate_type(Union[GridRefinementRegion, GridRefinementLine])
Clean implementation of the mesh refinement structures