-
Notifications
You must be signed in to change notification settings - Fork 2
docs: improve wording, add SSH method #8
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for implementing the changes. I left a few comments below.
My main feedback is regarding separating SSH and HTTPS method to different sections.
@@ -4,11 +4,14 @@ In this repository, various exercises for practicing Git and GitHub skills may b | |||
|
|||
## Prerequisites | |||
|
|||
[Install](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git) Git on your device. | |||
1. [Install](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git) Git on your device. | |||
2. Create a GitHub account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📖 Creating a GitHub account is also optional for the HTTPS method.
2. Create a GitHub account. | |
2. (SSH only) Create a GitHub account. |
|
||
## Setup | ||
|
||
Clone this repository using [HTTPS](https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls). | ||
Download this repository using [HTTPS](https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔡 Nitpick: The technical term is cloning.
Download this repository using [HTTPS](https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls). | |
Clone this repository using [HTTPS](https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls). |
|
||
## Setup | ||
|
||
Clone this repository using [HTTPS](https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls). | ||
Download this repository using [HTTPS](https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-https-urls). | ||
Alternatively using [SSH](https://docs.github.com/en/get-started/getting-started-with-git/about-remote-repositories#cloning-with-ssh-urls) | ||
|
||
```bash | ||
git clone https://github.com/flowup/git-workshop.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📖 Documentation structure: The link is only for HTTPS. Perhaps the HTTPS method could be in a separate h3
section, so that the differences between setup via each method are clear. What do you think?
Closes #7
In this PR, I am expanding the main
README
documentation by describing the SSH cloning method.The information was taken from the official Git documentation.