Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[property editor] consider badging individual dropdown items as default instead of property UI #8713

Open
kenzieschmoll opened this issue Jan 14, 2025 · 3 comments
Labels
analysis-server-change-needed issues that require a corresponding change to the Analysis Server P2 important to work on, but not at the top of the work list. property editor

Comments

@kenzieschmoll
Copy link
Member

When I opened a dropdown list for an enum value, I found myself wanting to know which value was the default value. If we were to badge the individual dropdown items instead of the entire property row, it would be easy to know which value is the default.

Image

Image

The problem with badging the property row instead of the dropdown item is that, if the selection is a non-default value, you have no way of knowing which value is the default based on the UI:

Image

Image

@kenzieschmoll kenzieschmoll added P2 important to work on, but not at the top of the work list. property editor labels Jan 14, 2025
@elliette elliette added the analysis-server-change-needed issues that require a corresponding change to the Analysis Server label Jan 23, 2025
@elliette
Copy link
Member

elliette commented Jan 23, 2025

This will require a change to the analysis server API to return the "defaultValue" of a parameter. I've added that field to the API spec. FYI @DanTup as well

@kenzieschmoll
Copy link
Member Author

Don't we already know this information? How are we applying the "default" badge today? This FR was a request to move the placement of that "default" badge to the dropdown item itself instead of having it be on the right of the dropdown menu.

@DanTup
Copy link
Contributor

DanTup commented Jan 23, 2025

Today we only provide a boolean for whether the current value is the default, but for this we'll need to provide the actual default value so it can be compared against things that aren't the current value.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
analysis-server-change-needed issues that require a corresponding change to the Analysis Server P2 important to work on, but not at the top of the work list. property editor
Projects
None yet
Development

No branches or pull requests

3 participants