[Property Editor] Use defaultValue instead of isDefault to determine default value
#8884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenzieschmoll
approved these changes
Feb 12, 2025
|
cc @DanTup - once this lands it should be safe to submit https://dart-review.googlesource.com/c/sdk/+/406621 |
|
Thanks! I don't have permission to merge it but I pinged on the issue so Brian can. Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #8713
Work towards #1948
defaultValueadded in https://dart-review.googlesource.com/c/sdk/+/406000isDefaultto unblock https://dart-review.googlesource.com/c/sdk/+/406621Also updates how the tests are written to make it clearer that the property inputs match the expected values.