Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[CQ] Numeric issues: fix implicit casts #8005

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

pq
Copy link
Contributor

@pq pq commented Apr 4, 2025

Implicit casts can lead to lossy conversions.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@pq pq requested a review from jwren April 4, 2025 17:43
@jwren
Copy link
Member

jwren commented Apr 4, 2025

LGTM, I am all about general cleanup PRs, we also want to make sure though that the better cleanup here isn't to just remove the files entirely :)

@pq
Copy link
Contributor Author

pq commented Apr 4, 2025

Heh. I actually forgot to add a question to this PR. Thanks for noticing!

You're dead-on. FlutterFramesMonitor is potentially unused (or only indirectly) and I've added to a list of classes to consider for removal. Thanks!

@jwren jwren merged commit 0308f07 into flutter:master Apr 4, 2025
8 of 9 checks passed
@pq pq deleted the cq_numeric_implicitCasts branch April 4, 2025 21:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants