Add a PR template that explains updating tests.version
#445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
reviewed
Jan 23, 2025
Co-authored-by: Zachary Anderson <zanderso@users.noreply.github.com>
|
Ping |
Piinks
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Can we add the content from the normal PR template? I think this will override the default like the prelaunch checklist here: #420
IIRC the repo falls back to the org default in the flutter/.github repo here: https://github.com/flutter/.github/blob/main/PULL_REQUEST_TEMPLATE.md
Done. |
victoreronmosele
pushed a commit
to victoreronmosele/tests
that referenced
this pull request
Feb 5, 2025
Part of flutter/flutter#162048. This can be of course tweaked and improved.
gnprice
added a commit
to gnprice/flutter
that referenced
this pull request
Feb 5, 2025
Looks like this is the first roll since this pin was introduced in flutter#162041 / flutter#162048. For fun and the possible convenience of the next person doing one of these, here's the command I used to generate the log below: $ git log --oneline --no-decorate --format='%cs %aE %s' b4cc09721.. \ | perl -pe 's,#,flutter/tests#,g' flutter/tests@b4cc097...6a6d096 2025-02-05 greg@zulip.com Re-land "Update Zulip tests and re-enable (flutter/tests#441)" (flutter/tests#446) 2025-01-30 goderbauer@google.com Update contact for pkg:animations (flutter/tests#447) 2025-01-24 matanlurey@users.noreply.github.com Add a PR template that explains updating `tests.version` (flutter/tests#445)
9 tasks
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 5, 2025
Looks like this is the first roll since this pin was introduced in #162041 / #162048. For fun and the possible convenience of the next person doing one of these, here's the command I used to generate the log below: $ git log --oneline --no-decorate --format='%cs %aE %s' b4cc09721.. \ | perl -pe 's,#,flutter/tests#,g' flutter/tests@b4cc097...6a6d096 2025-02-05 greg@zulip.com Re-land "Update Zulip tests and re-enable (flutter/tests#441)" (flutter/tests#446) 2025-01-30 goderbauer@google.com Update contact for pkg:animations (flutter/tests#447) 2025-01-24 matanlurey@users.noreply.github.com Add a PR template that explains updating `tests.version` (flutter/tests#445) ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#162048.
This can be of course tweaked and improved.