Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FIO-9855 removed deprecated settings #6053

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HannaKurban
Copy link
Contributor

@HannaKurban HannaKurban commented Mar 19, 2025

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9855

Description

Since the indexeddb option was deleted according to FIO-4103,the corresponding properties for dataSrc ===' indexeddb' condition were deleted from Data tab of Modal Edit window for Select Component. At the same time, all the functionality for dataSrc ===' indexeddb' was remained unchanged.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

locally. All tests pass locally

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

Copy link
Contributor

@johnformio johnformio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the DataTable.edit.fetch.ts, I think it's also removing these fields, but doing it in a different way. If that's the case, then we should be consistent in how we do this. If that's not what it's doing then let me know.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants