Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

FIO-9889: added backwards compatibility checks for provider options #6055

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZenMasterJacob20011
Copy link
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9889

Description

What changed?

Added a backwards compatibility check that will populate the appropriate JSON properties for the address component.

Why have you chosen this solution?

If someone's address JSON is using the legacy providerOptions object this will take the properties of that object and assign them to the new JSON properties. e.g. this.component.providerOptions.params.key would be assigned to this.component.apiKey

Breaking Changes / Backwards Compatibility

N/A

Dependencies

N/A

How has this PR been tested?

Manually tested

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant