Skip to content

[WIP] More fixes to FormData drag and drop and typing, and adds tests #19900

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

ahmedhamidawan
Copy link
Member

@ahmedhamidawan ahmedhamidawan commented Mar 25, 2025

Follows up to changes in #19866

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

For some reason, I had to use a counter `ref` to trigger this update as without it (a computed on `keepOptions`, turning `keepOptions` itself to a `ref` etc) did not update when `keepOptions` was changed.
This refers to `FormData` elements without the collection variant (only single or multiple dataset variants).

Explained in galaxyproject#19866 (comment)
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant