Use selectedItems composable in GridList
#20018
Draft
+1,200
−855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handles selections as well as keyboard navigation. Currently aims to replace `client/src/components/History/Content/SelectedItems.js`. Made it a reusable composable instead of just scoped to history items.
The structure of the `itemRefs` can be variable since we can have either a Component, DOM Element or an array of either as the ref.
Also improves how the existing arrow navigation is emitted (simpler `keydown` event in child `WorkflowCard` rather than what we had in `WorkflowCardList`).
Goes off of the (to be removed) existing `client/src/components/History/Content/SelectedItems.test.js` test, some parts still a TODO.
Uses the newly added composable in grids as well. Depends on galaxyproject#19973 Use this as an opportunity to add documentation for the composable as well.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the newly added composable in grids as well.
Depends on #19973
TODO:
Use this as an opportunity to add documentation for the composable as well.
How to test the changes?
(Select all options that apply)
License