Update ReadMe.md and add workflow dispatch #14
Conversation
davidmfinol
requested review from
GabLeRoux,
frostebite,
webbertakken and
AndrewKahr
| UNITY_PASSWORD: ${{ secrets.UNITY_PASSWORD }} | ||
| PROJECT_PATH: . | ||
|
|
||
| ### Refer to https://game.ci/docs/github/getting-started | ||
| jobs: | ||
| checklicense: |
There was a problem hiding this comment.
Should this be a job that we recommend? It feels like something you check once on setup rather than incur the cost for every CI run. It also doesn't capture the other complexities like using a serial number or licensing server instead of a license file.
There was a problem hiding this comment.
Right, I don't think we should recommend that they run this job every time.
On the game.ci docs website, we have activation as a separate workflow.
I think the goal for this repo is just to provide a very concise example, where a user could just clone the repo and quickly get a basic understanding of how to use the unity actions.
| fail-fast: false | ||
| matrix: | ||
| targetPlatform: | ||
| - WSAPlayer |
There was a problem hiding this comment.
Why is WSA player getting a separate workflow from the rest?
There was a problem hiding this comment.
because of the runs-on? I'm not sure but I think that's the reason. edit: I scrolled a bit more and now I don't see why either 😅
There was a problem hiding this comment.
I remember running into the license limitations with my paid license, when I would try running StandaloneWindows, StandaloneWindows64, and WSAPlayer in parallel.
I split off WSAPlayer from the other 2 in my personal workflow to avoid that issue, but maybe that's not necessary for a free license?
Co-authored-by: Webber Takken <webber.nl@gmail.com>
Yes to both. The goal is to build for Windows, allowing for either IL2CPP or Mono as the backend. If the user chooses IL2CPP, then building on Windows would also be required. |
Great! I wasn't asking the question for myself though. Could you please reflect |
Sure, I'll raise a new PR. |
Changes
Checklist
code of conduct