Skip to content

Restrict custom binary and graphics digits #1693

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
May 22, 2025
Merged

Restrict custom binary and graphics digits #1693

merged 4 commits into from
May 22, 2025

Conversation

Rangi42
Copy link
Contributor

@Rangi42 Rangi42 commented May 17, 2025

Fixes #1689

@Rangi42 Rangi42 added bug Unexpected behavior / crashes; to be fixed ASAP! enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM labels May 17, 2025
@Rangi42 Rangi42 requested a review from ISSOtm May 17, 2025 16:38
@Rangi42 Rangi42 force-pushed the numeric-literals branch from 0663201 to 701813b Compare May 17, 2025 16:41
@Rangi42 Rangi42 added this to the 0.9.3 milestone May 17, 2025
@Rangi42 Rangi42 force-pushed the numeric-literals branch from 701813b to 1d053a4 Compare May 18, 2025 14:36
@Rangi42 Rangi42 force-pushed the numeric-literals branch from 1d053a4 to 17a51ec Compare May 18, 2025 14:45
ISSOtm
ISSOtm requested changes May 18, 2025
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The idea looks good, though there is some bikeshedding about what to do with the built-in defaults.

ISSOtm
ISSOtm previously requested changes May 18, 2025
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to make it more obvious that the defaults remain available.

@Rangi42 Rangi42 requested a review from ISSOtm May 19, 2025 17:37
ISSOtm
ISSOtm approved these changes May 22, 2025
View reviewed changes
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ISSOtm ISSOtm merged commit 5d998ef into gbdev:master May 22, 2025
23 checks passed
@Rangi42 Rangi42 deleted the numeric-literals branch May 22, 2025 12:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ISSOtm ISSOtm ISSOtm approved these changes

Assignees
No one assigned
Labels
bug Unexpected behavior / crashes; to be fixed ASAP! enhancement Typically new features; lesser priority than bugs rgbasm This affects RGBASM
Projects
None yet
Milestone
0.9.3
Development

Successfully merging this pull request may close these issues.

Simplify how the binary and graphics digit options (b and g) work
2 participants
@Rangi42 @ISSOtm