added possibility to specify rsync binary using option rsync_binary #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
gchamon
requested changes
May 29, 2022
| @@ -38,7 +40,7 @@ def get_rsync_command(source: str, | |||
| if options is None: | |||
| options = [] | |||
|
|
|||
| return ['rsync', | |||
| return [rsync_cmd, | |||
There was a problem hiding this comment.
the argument is called rsync_binary, but here, it is rsync_cmd
Comment on lines
+11
to
+15
| rsync_args = inspect.getfullargspec(get_rsync_command)[0] | ||
| subp_kwargs = {} | ||
| for k, v in kwargs.items(): | ||
| if k not in rsync_args: | ||
| subp_kwargs[k] = v |
There was a problem hiding this comment.
maybe to avoid risking get_rsync_command and subprocess.run arguments collision, we could add a separate argument for sysrsync.run to pass those args to subprocess.run?
|
Sorry again. It's been a while (for some PRs quite longer than that), but I plan to give this project some attention (finally). Expect some updates this month. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful if you need to fix rsync to a specific version and dont want to require each users to modify their path.