Bug Fix: selected theme not loading when refreshing #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @0xh3xa, this looks like a perfect PR. When merging your other PR it caused conflicts with this one, would you be able to resolve them? :) |
|
@a3957273 Thanks for the heads-up! I'll resolve the conflicts shortly 👍 |
|
@a3957273 the conflict is resolved and the PR is ready :) |
|
Thanks, another great fix from you. :) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix Description:
applyPreferredColorScheme()method is invoked from thesetup()function inApp.mjs, which causes the dark or classic theme to load by default. The fix involves checking whether a theme is already loaded from storage before applying the preferred color scheme.Fix Video:
output.mp4