Add option to pass cookies to WMTS #995
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geographika
requested changes
May 17, 2025
There was a problem hiding this comment.
Thanks @ashergg. A couple of comments to address. Ideall0,y a test would be added too.
owslib/wmts.py
Outdated
| @@ -136,7 +136,7 @@ def __getitem__(self, name): | |||
| raise KeyError("No content named %s" % name) | |||
|
|
|||
| def __init__(self, url, version='1.0.0', xml=None, username=None, password=None, | |||
| parse_remote_metadata=False, vendor_kwargs=None, headers=None, auth=None, | |||
| parse_remote_metadata=False, vendor_kwargs=None, headers=None, cookies=None, auth=None, | |||
There was a problem hiding this comment.
It would be safer to add the new cookies parameter at the end of the list to avoid breaking existing codebases
owslib/wmts.py
Outdated
| @@ -887,7 +888,7 @@ class WMTSCapabilitiesReader: | |||
| """Read and parse capabilities document into a lxml.etree infoset | |||
| """ | |||
|
|
|||
| def __init__(self, version='1.0.0', url=None, un=None, pw=None, headers=None, auth=None): | |||
| def __init__(self, version='1.0.0', url=None, un=None, pw=None, headers=None, cookies=None, auth=None): | |||
There was a problem hiding this comment.
As above - move new argument to the end
|
Hi @geographika, thanks for the comments. I've added a test, and moved the arguments to the end. |
|
Thanks @ashergg ! This looks good to me, and +1 on merging. I'll leave open a few days to see if anyone else has any comments. |
geographika
approved these changes
May 18, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to pass cookies to the WMTS class. This can help when the server requires specific cookies.