Don't generate paging links if provider created them #1982
+28
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR changes itemtypes.py to allow providers to generate their own
'next'
links, which then disable the limit-offset paging built into pygeoapi. As discussed in #1981, we want to move away from limit-offset paging for the data we're serving from Postgres and move towards keyset paging instead, and I believe this change would let us handle that from within our provider.We just check for a next link in the response before disabling the generation of both prev and next links, as the Features standard mentions that prev links may be skipped based on implementation. As such, if the provider has generated a
next
link but not aprev
link, we assume that was intentional.Related Issue / discussion
#1981
Additional information
Dependency policy (RFC2)
Updates to public demo
Contributions and licensing
(as per https://github.com/geopython/pygeoapi/blob/master/CONTRIBUTING.md#contributions-and-licensing)