Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix indexing for reading rational or srational arrays #438

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sam6321
Copy link

@sam6321 sam6321 commented Sep 6, 2024

Fix for #437

@constantinius
Copy link
Member

Hi @sam6321

Thanks for providing the fix. It would be great if you could also add a testcase for that to demonstrate it works.

@sam6321
Copy link
Author

sam6321 commented Sep 6, 2024

Sure I can look at doing that

@sam6321
Copy link
Author

sam6321 commented Sep 8, 2024

@constantinius I tried to add the most minimal test case I could. I'm not sure how to add test files to the repository so I just put the file data inline in the code (it's not really that big so I hope that's okay).

I can instead provide the tiff file directly if that's more preferable

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants