-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat: add hooks for session replay #4974
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- add hooks for session replay ([#4974](https://github.com/getsentry/sentry-cocoa/pull/4974)) If none of the above apply, you can opt out of this check by adding |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4974 +/- ##
=============================================
- Coverage 92.436% 92.433% -0.004%
=============================================
Files 669 669
Lines 79226 79231 +5
Branches 28644 28649 +5
=============================================
+ Hits 73234 73236 +2
- Misses 5895 5899 +4
+ Partials 97 96 -1
... and 9 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f05aa59 | 1211.31 ms | 1249.73 ms | 38.42 ms |
b0e218b | 1218.14 ms | 1230.33 ms | 12.19 ms |
db533ee | 1228.96 ms | 1248.23 ms | 19.28 ms |
2af280d | 1226.46 ms | 1229.81 ms | 3.35 ms |
db31083 | 1252.52 ms | 1266.65 ms | 14.13 ms |
16c38a2 | 1228.38 ms | 1245.70 ms | 17.32 ms |
cf724da | 1243.14 ms | 1261.44 ms | 18.30 ms |
c0c1496 | 1201.19 ms | 1228.36 ms | 27.17 ms |
8fd8904 | 1221.69 ms | 1239.66 ms | 17.97 ms |
6bc5ae5 | 1207.23 ms | 1216.66 ms | 9.43 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f05aa59 | 22.30 KiB | 749.84 KiB | 727.54 KiB |
b0e218b | 21.58 KiB | 638.28 KiB | 616.70 KiB |
db533ee | 21.58 KiB | 547.02 KiB | 525.44 KiB |
2af280d | 20.76 KiB | 435.22 KiB | 414.46 KiB |
db31083 | 22.85 KiB | 407.62 KiB | 384.77 KiB |
16c38a2 | 21.90 KiB | 726.19 KiB | 704.29 KiB |
cf724da | 20.76 KiB | 430.52 KiB | 409.76 KiB |
c0c1496 | 22.85 KiB | 407.45 KiB | 384.60 KiB |
8fd8904 | 21.58 KiB | 656.60 KiB | 635.02 KiB |
6bc5ae5 | 20.76 KiB | 401.39 KiB | 380.63 KiB |
related: getsentry/sentry#86905 |
Closing as outdated |
📜 Description
These are two hooks that were side-effects while working on #4940
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps