Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

impr: Remove char limit of 8192 for SentryMessage #5005

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

philipphofmann
Copy link
Member

📜 Description

Let Relay truncate the max char length. The benefit is that users see that the message was truncated.

💡 Motivation and Context

Fixes GH-5004

💚 How did you test it?

Unit tests

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Let Relay truncate the max char length. The benefit is that users
see that the message was truncated.

Fixes GH-5004
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.694%. Comparing base (fd1c994) to head (1af6eda).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #5005       +/-   ##
=============================================
+ Coverage   92.608%   92.694%   +0.086%     
=============================================
  Files          672       672               
  Lines        82199     82199               
  Branches     28819     29840     +1021     
=============================================
+ Hits         76123     76194       +71     
+ Misses        5983      5906       -77     
- Partials        93        99        +6     
Files with missing lines Coverage Δ
Sources/Sentry/SentryMessage.m 100.000% <100.000%> (ø)
...ests/SentryTests/Protocol/SentryMessageTests.swift 100.000% <100.000%> (ø)

... and 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd1c994...1af6eda. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit 6e196fe into main Mar 24, 2025
72 of 75 checks passed
@philipphofmann philipphofmann deleted the impr/message-char-limit branch March 24, 2025 14:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove truncation logic for SentryMessage
2 participants