Skip to content

fix(session-replay): add masking improvements #5073

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

philprime
Copy link
Contributor

📜 Description

This is a WIP PR to review analysis attempts and improvements for session replay masking

💡 Motivation and Context

See #4864

#skip-changelog

@philprime philprime self-assigned this Apr 9, 2025
@philprime philprime moved this to In Progress in Mobile SDKs Apr 9, 2025
@philprime philprime moved this from In Progress to In Investigation in Mobile SDKs Apr 9, 2025
@philprime philprime mentioned this pull request Apr 8, 2025
4 tasks
Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 0.45662% with 218 lines in your changes missing coverage. Please review.

Project coverage is 8.918%. Comparing base (ef25af3) to head (7260f00).

Files with missing lines Patch % Lines
...urces/Swift/Tools/ViewRedaction/RedactRegion.swift 0.000% 51 Missing ⚠️
...egrations/SessionReplay/SentryOnDemandReplay.swift 0.000% 46 Missing ⚠️
...es/Swift/Tools/ViewRedaction/UIRedactBuilder.swift 0.000% 42 Missing ⚠️
.../Swift/Tools/ViewRedaction/ViewHierarchyNode.swift 0.000% 35 Missing ⚠️
...tegrations/SessionReplay/SentrySessionReplay.swift 0.000% 19 Missing ⚠️
...rations/SessionReplay/SentryReplayVideoMaker.swift 0.000% 9 Missing ⚠️
Sources/Sentry/SentrySessionReplayIntegration.m 0.000% 7 Missing ⚠️
.../Tools/ViewCapture/SentryDefaultMaskRenderer.swift 0.000% 3 Missing ⚠️
...ift/Tools/ViewCapture/SentryViewPhotographer.swift 0.000% 3 Missing ⚠️
Sources/Sentry/include/SentryDisplayLinkWrapper.m 0.000% 1 Missing ⚠️
... and 2 more

❗ There is a different number of reports uploaded between BASE (ef25af3) and HEAD (7260f00). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (ef25af3) HEAD (7260f00)
4 1
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main    #5073        +/-   ##
=============================================
- Coverage   92.735%   8.918%   -83.818%     
=============================================
  Files          674      360       -314     
  Lines        83547    25913     -57634     
  Branches     30442       94     -30348     
=============================================
- Hits         77478     2311     -75167     
- Misses        5972    23602     +17630     
+ Partials        97        0        -97     
Files with missing lines Coverage Δ
...tegrations/SessionReplay/SentryReplayOptions.swift 22.580% <100.000%> (-73.310%) ⬇️
Sources/Sentry/include/SentryDisplayLinkWrapper.m 0.000% <0.000%> (-100.000%) ⬇️
...ssionReplay/Preview/SentryMaskingPreviewView.swift 0.000% <0.000%> (-86.275%) ⬇️
...s/ViewCapture/SentryExperimentalMaskRenderer.swift 0.000% <0.000%> (ø)
.../Tools/ViewCapture/SentryDefaultMaskRenderer.swift 0.000% <0.000%> (-100.000%) ⬇️
...ift/Tools/ViewCapture/SentryViewPhotographer.swift 0.000% <0.000%> (-73.334%) ⬇️
Sources/Sentry/SentrySessionReplayIntegration.m 0.000% <0.000%> (-88.611%) ⬇️
...rations/SessionReplay/SentryReplayVideoMaker.swift 0.000% <0.000%> (-100.000%) ⬇️
...tegrations/SessionReplay/SentrySessionReplay.swift 0.000% <0.000%> (-97.657%) ⬇️
.../Swift/Tools/ViewRedaction/ViewHierarchyNode.swift 0.000% <0.000%> (ø)
... and 3 more

... and 655 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef25af3...7260f00. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.98 ms 1252.28 ms 30.30 ms
Size 22.30 KiB 860.34 KiB 838.03 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ff5f4e7 1241.34 ms 1258.04 ms 16.70 ms
596ccc1 1223.80 ms 1249.44 ms 25.64 ms
8fd8904 1221.69 ms 1239.66 ms 17.97 ms
f5c35a1 1227.98 ms 1232.84 ms 4.86 ms
a34f08c 1234.08 ms 1246.40 ms 12.31 ms
26d116c 1196.14 ms 1209.51 ms 13.37 ms
f2daa68 1211.14 ms 1217.53 ms 6.39 ms
326b7eb 1252.86 ms 1259.56 ms 6.70 ms
b8dd0fc 1268.96 ms 1271.90 ms 2.94 ms
d9f518a 1227.87 ms 1248.19 ms 20.31 ms

App size

Revision Plain With Sentry Diff
ff5f4e7 21.58 KiB 572.91 KiB 551.33 KiB
596ccc1 22.84 KiB 401.44 KiB 378.59 KiB
8fd8904 21.58 KiB 656.60 KiB 635.02 KiB
f5c35a1 22.31 KiB 768.83 KiB 746.52 KiB
a34f08c 22.30 KiB 730.30 KiB 708.00 KiB
26d116c 21.58 KiB 417.87 KiB 396.29 KiB
f2daa68 21.58 KiB 418.40 KiB 396.82 KiB
326b7eb 20.76 KiB 432.31 KiB 411.55 KiB
b8dd0fc 20.76 KiB 401.39 KiB 380.63 KiB
d9f518a 22.30 KiB 730.75 KiB 708.45 KiB

@philprime philprime added the dontmerge A branch that absolutely should not be merged while this label is applied. label Apr 9, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dontmerge A branch that absolutely should not be merged while this label is applied. Platform: Cocoa Session Replay
Projects
Status: In Investigation
Development

Successfully merging this pull request may close these issues.

1 participant