-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Don't gate request query strings and form data behind send_default_pii #2452
base: 6.0-dev
Are you sure you want to change the base?
Conversation
78c4fe5
to
f1c1f1f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 6.0-dev #2452 +/- ##
===========================================
+ Coverage 97.94% 98.06% +0.12%
===========================================
Files 126 126
Lines 4714 4708 -6
===========================================
Hits 4617 4617
+ Misses 97 91 -6
|
55bbe4d
to
ca51cc7
Compare
ca51cc7
to
c6d6137
Compare
The failing test seems to be about new behavior rails 7.2 and will be fixed separately |
Query strings should not be guarded by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think send_default_pii
should be applied to body.
@@ -20,7 +20,7 @@ def record_sentry_breadcrumb(request_info, response_status) | |||
level: :info, | |||
category: self.class::BREADCRUMB_CATEGORY, | |||
type: :info, | |||
data: { status: response_status, **request_info } | |||
data: { status: response_status, **request_info.compact } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, this should be called at the caller's extract_request_info
helpers.
This makes it consistent with behavior in other SDKs.
But since it changes behavior, we will release it as part of the next major.