[active_job] support exception reporting only after last retry failed #2573
+111
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
force-pushed
the
solnic/pr-2500-follow-up
branch
4 times, most recently
from
4ab9ff9 to
b26b17a
Compare
solnic
force-pushed
the
solnic/pr-2500-follow-up
branch
2 times, most recently
from
90144c4 to
2fa01fc
Compare
solnic
force-pushed
the
solnic/pr-2500-follow-up
branch
from
2fa01fc to
d19050a
Compare
solnic
changed the title
solnic
force-pushed
the
solnic/pr-2500-follow-up
branch
from
d19050a to
36c1176
Compare
|
Please ignore Danger here, it just fails to see that I added CHANGELOG entry. |
st0012
approved these changes
Mar 29, 2025
| @@ -52,6 +54,10 @@ | |||
| expect(Sentry::Rails::Tracing.subscribed_tracing_events).to be_empty | |||
| Sentry::Rails::Tracing.remove_active_support_notifications_patch | |||
|
|
|||
| if defined?(Sentry::Rails::ActiveJobExtensions) | |||
There was a problem hiding this comment.
I think with our current setup this will always be true?
There was a problem hiding this comment.
@st0012 not really, it may or may not be defined, depending on the order of loading files which is pretty much random 🙃
Otherwise specs would be failing randomly
solnic
force-pushed
the
solnic/pr-2500-follow-up
branch
from
36c1176 to
4e59569
Compare
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- [active_job] support exception reporting only after last retry failed ([#2573](https://github.com/getsentry/sentry-ruby/pull/2573))If none of the above apply, you can opt out of this check by adding |
solnic
force-pushed
the
solnic/pr-2500-follow-up
branch
from
dc38bb6 to
4e59569
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #2500 which adds support for
active_job_report_after_job_retriesoption which makes reporting an exception upon a job failure to happen only on the last attempt retry failure.