Add sidekiq config propagate_traces to control trace header injection
#2588
+42
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
force-pushed
the
neel/sidekiq-propagate-traces
branch
from
c38d916 to
02a5e26
Compare
sl0thentr0py
changed the title
propagate_traces to control trace header injection
solnic
reviewed
Mar 19, 2025
| it "has correct default value" do | ||
| expect(subject.report_only_dead_jobs).to eq(false) | ||
| end | ||
| end |
There was a problem hiding this comment.
was missing so just added it
solnic
reviewed
Mar 19, 2025
|
|
||
| if Sentry.configuration.sidekiq.propagate_traces | ||
| job["trace_propagation_headers"] ||= Sentry.get_trace_propagation_headers | ||
| end |
There was a problem hiding this comment.
Isn't this a breaking change in a way? Previously it would do it unconditionally. Now you have to explicitly enable it. I understand that the original behavior was problematic though so maybe it's fine?
There was a problem hiding this comment.
it defaults to true
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2531
part of #2476